nextcloud /
circles
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 68 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | /* |
||
| 45 | $(document).ready(function () { |
||
| 46 | |||
| 47 | /** |
||
| 48 | * @constructs Navigation |
||
| 49 | */ |
||
| 50 | |||
| 51 | |||
| 52 | |||
| 53 | var Navigation = function () { |
||
| 54 | |||
| 55 | $.extend(Navigation.prototype, curr); |
||
| 56 | $.extend(Navigation.prototype, nav); |
||
| 57 | $.extend(Navigation.prototype, elements); |
||
| 58 | $.extend(Navigation.prototype, actions); |
||
| 59 | |||
| 60 | this.init(); |
||
| 61 | }; |
||
| 62 | |||
| 63 | |||
| 64 | Navigation.prototype = { |
||
| 65 | |||
| 66 | init: function () { |
||
| 67 | elements.initElements(); |
||
| 68 | elements.initUI(); |
||
| 69 | elements.initTweaks(); |
||
| 70 | elements.initAnimationNewCircle(); |
||
| 71 | elements.initExperienceCirclesList(); |
||
| 72 | actions.initActions(); |
||
| 73 | |||
| 74 | } |
||
| 75 | }; |
||
| 76 | |||
| 77 | |||
| 78 | /** |
||
| 79 | * @constructs Notification |
||
| 80 | */ |
||
| 81 | var Notification = function () { |
||
| 82 | this.initialize(); |
||
| 83 | }; |
||
| 84 | |||
| 85 | Notification.prototype = { |
||
| 86 | |||
| 87 | initialize: function () { |
||
| 88 | |||
| 89 | //noinspection SpellCheckingInspection |
||
| 90 | var notyf = new Notyf({ |
||
| 91 | delay: 5000 |
||
| 92 | }); |
||
| 93 | |||
| 94 | this.onSuccess = function (text) { |
||
| 95 | notyf.confirm(text); |
||
| 96 | }; |
||
| 97 | |||
| 98 | this.onFail = function (text) { |
||
| 99 | notyf.alert(text); |
||
| 100 | }; |
||
| 101 | |||
| 102 | } |
||
| 103 | |||
| 104 | }; |
||
| 105 | |||
| 106 | OCA.Circles.Navigation = Navigation; |
||
| 107 | OCA.Circles.navigation = new Navigation(); |
||
| 108 | |||
| 109 | OCA.Notification = Notification; |
||
| 110 | OCA.notification = new Notification(); |
||
| 111 | |||
| 112 | }); |
||
| 113 | |||
| 114 |
